-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Gogs pulls as issue #14394
Migrate Gogs pulls as issue #14394
Conversation
ce0c913
to
8fd5850
Compare
|
||
issue := convertGogsIssue(gogsIssue) | ||
|
||
issue.Title = "[Pull] " + issue.Title |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can actually just create PRs with missing heads or even just make fake ones ourselves
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have no base and no head
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☝️ with this all you get is a broken pull
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Cat7373 you as one who potentially use this migrator ... what are your thoughts about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zeripath tested to create pull with only issue information: get failed: Unsupported scheme:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I forgot we don't have a base. We have a head it's simply refs/pulls/xxx/head - the base is the issue.
Since it's impossible, just disable the checkbox. I don't think there is any meaning to place an issue as pull request . |
For documentation/archivation porpuse ... |
No codes, commits and code comments there. They will only make users confusing. |
extent #14342 ...
Migrate pulls as pulls is not posible, because gogs do not provide needed information over api