Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Gogs pulls as issue #14394

Closed
wants to merge 4 commits into from
Closed

Conversation

6543
Copy link
Member

@6543 6543 commented Jan 19, 2021

extent #14342 ...

Migrate pulls as pulls is not posible, because gogs do not provide needed information over api

@6543 6543 added type/enhancement An improvement of existing functionality topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR labels Jan 19, 2021
@6543 6543 added this to the 1.14.0 milestone Jan 19, 2021
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 19, 2021
@6543 6543 removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Jan 21, 2021
@6543 6543 force-pushed the gogs-pulls-as-issue branch from ce0c913 to 8fd5850 Compare January 21, 2021 19:57
@go-gitea go-gitea deleted a comment from codecov-io Jan 21, 2021

issue := convertGogsIssue(gogsIssue)

issue.Title = "[Pull] " + issue.Title
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can actually just create PRs with missing heads or even just make fake ones ourselves

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have no base and no head

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☝️ with this all you get is a broken pull

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cat7373 you as one who potentially use this migrator ... what are your thoughts about it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeripath tested to create pull with only issue information: get failed: Unsupported scheme:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I forgot we don't have a base. We have a head it's simply refs/pulls/xxx/head - the base is the issue.

@lunny
Copy link
Member

lunny commented Jan 22, 2021

Since it's impossible, just disable the checkbox. I don't think there is any meaning to place an issue as pull request .

@6543
Copy link
Member Author

6543 commented Jan 22, 2021

For documentation/archivation porpuse ...

@lunny
Copy link
Member

lunny commented Jan 22, 2021

For documentation/archivation porpuse ...

No codes, commits and code comments there. They will only make users confusing.

@6543 6543 removed this from the 1.14.0 milestone Jan 22, 2021
@6543 6543 added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Jan 27, 2021
@6543 6543 closed this Jun 18, 2021
@6543 6543 deleted the gogs-pulls-as-issue branch June 18, 2021 00:39
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants