-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix access log #14475
Fix access log #14475
Conversation
1498429
to
dcbd2a4
Compare
dcbd2a4
to
7429a01
Compare
@lunny can you use middleware instead of middlewares? |
see #14475 (comment) |
Codecov Report
@@ Coverage Diff @@
## master #14475 +/- ##
==========================================
- Coverage 42.11% 42.10% -0.01%
==========================================
Files 758 760 +2
Lines 81085 81103 +18
==========================================
+ Hits 34148 34149 +1
- Misses 41360 41375 +15
- Partials 5577 5579 +2
Continue to review full report at Codecov.
|
☝️ since it's breaking ... |
Fix #14121, #14478.
The
AccessLog
middleware has to be afterContexter
orAPIContexter
so that we can getLoginUserName
if possible.And also there is a BREAK change that it removed internal API access log.