Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print usefull error if SQLite is used in settings but not supported #14476

Merged
merged 5 commits into from
Jan 27, 2021
Merged

Print usefull error if SQLite is used in settings but not supported #14476

merged 5 commits into from
Jan 27, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Jan 26, 2021

as title

@6543 6543 added type/enhancement An improvement of existing functionality skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 26, 2021
@6543 6543 added this to the 1.14.0 milestone Jan 26, 2021
@6543 6543 changed the title Move log output to points where they are relefant Print usefull error if SQLite is used in settings but not supported Jan 26, 2021
@6543 6543 added type/bug backport/v1.13 and removed type/enhancement An improvement of existing functionality skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 26, 2021
@codecov-io
Copy link

codecov-io commented Jan 26, 2021 •
edited
Loading

Codecov Report

Merging #14476 (000410d) into master (a598877) will increase coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14476   +/-   ##
=======================================
  Coverage   42.12%   42.13%           
=======================================
  Files         758      758           
  Lines       81080    81085    +5     
=======================================
+ Hits        34155    34163    +8     
+ Misses      41352    41351    -1     
+ Partials     5573     5571    -2
Impacted Files Coverage Δ
routers/init.go 44.76% <20.00%> (-0.87%) ⬇️
models/issue.go 57.24% <100.00%> (+0.10%) ⬆️
services/pull/check.go 48.52% <0.00%> (-2.21%) ⬇️
models/error.go 39.48% <0.00%> (-0.49%) ⬇️
services/pull/pull.go 42.64% <0.00%> (+0.49%) ⬆️
models/gpg_key.go 53.90% <0.00%> (+0.57%) ⬆️
modules/charset/charset.go 73.03% <0.00%> (+4.49%) ⬆️
modules/avatar/avatar.go 54.76% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5845c87...000410d. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 26, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 27, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 27, 2021
@6543 6543 merged commit b2c20b6 into go-gitea:master Jan 27, 2021
@6543 6543 deleted the print-sqlite-support-before-xorm-init branch January 27, 2021 03:57
@zeripath
Copy link
Contributor

zeripath commented Mar 1, 2021

@6543 Please send backport

6543 added a commit to 6543-forks/gitea that referenced this pull request Mar 3, 2021
@6543
Print usefull error if SQLite is used in settings but not supported (g…
7e2b69f 
…o-gitea#14476)

* move log output to points where they are relefant

* check explicit of sqlite3 in settings
@6543 6543 mentioned this pull request Mar 3, 2021
Merged
@6543 6543 added the backport/done All backports for this PR have been created label Mar 3, 2021
zeripath pushed a commit that referenced this pull request Mar 3, 2021
@6543
Print usefull error if SQLite is used in settings but not supported (#…
7e85cba 
…14476) (#14874)

* move log output to points where they are relefant

* check explicit of sqlite3 in settings
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a1012112796 a1012112796 a1012112796 approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
6 participants
@6543 @codecov-io @zeripath @lunny @a1012112796 @GiteaBot