Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rate limit bug when downloading assets on migrating from github #14564

Merged
merged 2 commits into from
Feb 7, 2021
Merged

Fix rate limit bug when downloading assets on migrating from github #14564

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
930fdd1
Fix rate limit bug when downloading assets on migrating from github
lunny Feb 4, 2021
4a5a085
Merge branch 'master' into lunny/fix_sleep
zeripath Feb 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions modules/migrations/github.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,10 +301,15 @@ func (g *GithubDownloaderV3) convertGithubRelease(rel *github.RepositoryRelease)
Created: asset.CreatedAt.Time,
Updated: asset.UpdatedAt.Time,
DownloadFunc: func() (io.ReadCloser, error) {
g.sleep()
asset, redir, err := g.client.Repositories.DownloadReleaseAsset(g.ctx, g.repoOwner, g.repoName, *asset.ID, http.DefaultClient)
if err != nil {
return nil, err
}
err = g.RefreshRate()
if err != nil {
log.Error("g.client.RateLimits: %s", err)
}
lunny marked this conversation as resolved.
Show resolved Hide resolved
6543 marked this conversation as resolved.
Show resolved Hide resolved
if asset == nil {
return ioutil.NopCloser(bytes.NewBufferString(redir)), nil
}
Expand Down