Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository transfer has to be confirmed, if user can not create repo for new owner #14792

Merged
merged 122 commits into from
Mar 1, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Feb 24, 2021

Screenshot at 2021-02-26 21-53-47

close #4743

@codecov-io
Copy link

Codecov Report

Merging #14792 (5dc7c1a) into master (3d8b5ad) will increase coverage by 0.04%.
The diff coverage is 39.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14792      +/-   ##
==========================================
+ Coverage   42.22%   42.26%   +0.04%     
==========================================
  Files         771      774       +3     
  Lines       82181    82476     +295     
==========================================
+ Hits        34697    34858     +161     
- Misses      41832    41941     +109     
- Partials     5652     5677      +25     
Impacted Files Coverage Δ
models/migrations/migrations.go 2.59% <ø> (ø)
models/migrations/v174.go 0.00% <0.00%> (ø)
modules/context/repo.go 53.83% <0.00%> (-1.11%) ⬇️
modules/convert/notification.go 52.27% <0.00%> (-8.26%) ⬇️
routers/repo/repo.go 28.73% <0.00%> (-2.65%) ⬇️
routers/repo/setting.go 14.37% <0.00%> (-0.53%) ⬇️
services/mailer/mail.go 61.70% <ø> (ø)
routers/repo/view.go 41.64% <25.00%> (+0.48%) ⬆️
modules/notification/mail/mail.go 38.54% <33.33%> (-0.17%) ⬇️
modules/notification/ui/ui.go 64.10% <33.33%> (-0.81%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d8b5ad...5dc7c1a. Read the comment docs.

models/notification.go Outdated Show resolved Hide resolved
models/notification.go Outdated Show resolved Hide resolved
models/org.go Show resolved Hide resolved
models/repo_transfer.go Outdated Show resolved Hide resolved
models/repo_transfer.go Show resolved Hide resolved
modules/convert/notification.go Outdated Show resolved Hide resolved
services/mailer/mail_repo.go Outdated Show resolved Hide resolved
services/repository/transfer.go Outdated Show resolved Hide resolved
templates/repo/header.tmpl Outdated Show resolved Hide resolved
templates/repo/settings/options.tmpl Outdated Show resolved Hide resolved
@6543 6543 requested a review from zeripath February 28, 2021 13:52
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 28, 2021
models/repo_transfer.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 1, 2021
@6543 6543 merged commit a4148c0 into go-gitea:master Mar 1, 2021
@6543 6543 deleted the repo_transfer branch March 1, 2021 00:47
@adelowo
Copy link
Member

adelowo commented Mar 9, 2021

Thanks for wrapping this PR up @6543.

@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transfer repo ownership should be confirmed by new owner
6 participants