Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mismatched closed div in sidebar.tmpl #14825

Conversation

zeripath
Copy link
Contributor

Fix #14719

Signed-off-by: Andrew Thornton art27@cantab.net

Fix go-gitea#14719

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.14.0 milestone Feb 27, 2021
@zeripath
Copy link
Contributor Author

sidebar.tmpl needs to be completely reindented as it appears there's a mismatched {{end}} at the end of the file.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 27, 2021
@6543 6543 mentioned this pull request Feb 27, 2021
@codecov-io
Copy link

Codecov Report

Merging #14825 (722a869) into master (3d8b5ad) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14825   +/-   ##
=======================================
  Coverage   42.22%   42.22%           
=======================================
  Files         771      771           
  Lines       82181    82181           
=======================================
+ Hits        34697    34702    +5     
+ Misses      41832    41828    -4     
+ Partials     5652     5651    -1     
Impacted Files Coverage Δ
routers/repo/view.go 41.78% <0.00%> (+0.62%) ⬆️
modules/process/manager.go 75.30% <0.00%> (+2.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d8b5ad...722a869. Read the comment docs.

@6543
Copy link
Member

6543 commented Feb 28, 2021

@zeripath took me some time, but ... #14826 <- here it is, THIS pull didn't fix it & automatical line reindent just make it worse ... so I had to go throu it by had :/

  • found a other (related) bug

@zeripath
Copy link
Contributor Author

Closed in favour of #14826

@zeripath zeripath closed this Feb 28, 2021
@zeripath zeripath deleted the fix-14719-fix-mismatch-div-close-sidebar branch February 28, 2021 07:35
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer broken when disabling dependencies
4 participants