Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub: migrate draft releases too #15884

Merged

Conversation

6543
Copy link
Member

@6543 6543 commented May 15, 2021

close https://codeberg.org/Codeberg/Community/issues/447

to reproduce:

  1. create draft release
  2. try to migrate with releases

@6543 6543 added type/bug topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them backport/v1.14 labels May 15, 2021
@6543 6543 added this to the 1.15.0 milestone May 15, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 15, 2021

Codecov Report

Merging #15884 (a914033) into main (f582ec4) will decrease coverage by 0.09%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #15884      +/-   ##
==========================================
- Coverage   44.01%   43.91%   -0.10%     
==========================================
  Files         681      681              
  Lines       82316    82333      +17     
==========================================
- Hits        36230    36157      -73     
- Misses      40184    40287     +103     
+ Partials     5902     5889      -13     
Impacted Files Coverage Δ
modules/migrations/gitea_uploader.go 7.44% <0.00%> (-0.03%) ⬇️
modules/migrations/github.go 77.17% <50.00%> (-0.16%) ⬇️
modules/eventsource/manager.go 74.41% <75.00%> (+0.05%) ⬆️
modules/eventsource/manager_run.go 72.72% <78.94%> (+4.72%) ⬆️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
models/issue_comment.go 45.54% <0.00%> (-7.05%) ⬇️
modules/notification/ui/ui.go 58.97% <0.00%> (-6.84%) ⬇️
modules/notification/mail/mail.go 33.67% <0.00%> (-5.11%) ⬇️
modules/git/commit.go 52.15% <0.00%> (-4.32%) ⬇️
modules/notification/base/null.go 76.31% <0.00%> (-2.64%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e32eeb...a914033. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 15, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 15, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 15, 2021
@techknowlogick techknowlogick merged commit e0c93fe into go-gitea:main May 15, 2021
@6543 6543 deleted the migration-make-draft-releases-work branch May 15, 2021 23:33
6543 added a commit to 6543-forks/gitea that referenced this pull request May 15, 2021
* GitHub: migrate draft releases too

* refactor
@6543
Copy link
Member Author

6543 commented May 15, 2021

-> #15888

@6543 6543 added the backport/done All backports for this PR have been created label May 15, 2021
6543 added a commit that referenced this pull request May 16, 2021
* GitHub: migrate draft releases too

* refactor
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
* GitHub: migrate draft releases too

* refactor
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants