Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix documentation for IIS reverse proxy configuration #16246

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

nexero
Copy link
Contributor

@nexero nexero commented Jun 25, 2021

fix #16245 as pull requests won't work properly otherwise

@codecov-commenter
Copy link

Codecov Report

Merging #16246 (ae2753c) into main (0393a57) will increase coverage by 1.25%.
The diff coverage is 49.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16246      +/-   ##
==========================================
+ Coverage   44.24%   45.49%   +1.25%     
==========================================
  Files         695      705      +10     
  Lines       82341    83167     +826     
==========================================
+ Hits        36429    37840    +1411     
+ Misses      40014    39262     -752     
- Partials     5898     6065     +167     
Impacted Files Coverage Δ
cmd/generate.go 0.00% <0.00%> (ø)
cmd/hook.go 0.00% <0.00%> (ø)
models/action.go 47.12% <ø> (ø)
models/oauth2.go 28.00% <0.00%> (-1.17%) ⬇️
models/repo_archiver.go 0.00% <0.00%> (ø)
models/user.go 52.32% <ø> (-1.07%) ⬇️
modules/context/repo.go 52.99% <0.00%> (-0.30%) ⬇️
modules/generate/generate.go 0.00% <0.00%> (-16.00%) ⬇️
modules/git/error.go 50.00% <0.00%> (-4.24%) ⬇️
modules/git/last_commit_cache_nogogit.go 35.84% <0.00%> (+0.66%) ⬆️
... and 189 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 837e8b3...ae2753c. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 25, 2021
@@ -221,6 +221,9 @@ If you wish to run Gitea with IIS. You will need to setup IIS with URL Rewrite a
```xml
<?xml version="1.0" encoding="UTF-8"?>
<configuration>
<system.web>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so looking at the docs here it appears by default that the following characters are disallowed:

<,>,*,%,&,:,\

I guess we really only need the : but gitea is safe with all of these characters.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 25, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 25, 2021
@6543 6543 merged commit 7a0ed9a into go-gitea:main Jun 25, 2021
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IIS Reverse Proxy Settings: Pull Requests require additional Parameter
5 participants