Skip to content

Conversation

sebastian-sauer
Copy link
Contributor

end is start + pageSize and not start + page

as mentioned in #16300

end is start + pageSize and not start + page
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 29, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #16303 (76c66df) into main (add74fb) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16303      +/-   ##
==========================================
+ Coverage   45.40%   45.41%   +0.01%     
==========================================
  Files         709      709              
  Lines       83500    83500              
==========================================
+ Hits        37912    37921       +9     
+ Misses      39497    39496       -1     
+ Partials     6091     6083       -8     
Impacted Files Coverage Δ
models/list_options.go 43.47% <0.00%> (ø)
services/mailer/mail_comment.go 77.77% <0.00%> (-7.41%) ⬇️
modules/avatar/avatar.go 47.72% <0.00%> (-4.55%) ⬇️
modules/log/event.go 58.96% <0.00%> (-0.95%) ⬇️
models/error.go 39.68% <0.00%> (+0.77%) ⬆️
models/notification.go 65.85% <0.00%> (+0.88%) ⬆️
modules/notification/mail/mail.go 36.27% <0.00%> (+0.98%) ⬆️
modules/notification/ui/ui.go 62.31% <0.00%> (+1.44%) ⬆️
services/pull/check.go 28.27% <0.00%> (+2.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update add74fb...76c66df. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 29, 2021
@zeripath zeripath added this to the 1.15.0 milestone Jun 29, 2021
@zeripath zeripath merged commit e8c6cea into go-gitea:main Jun 29, 2021
@zeripath

This comment has been minimized.

6543 pushed a commit to 6543-forks/gitea that referenced this pull request Jun 29, 2021
end is start + pageSize and not start + page
@6543 6543 added the backport/done All backports for this PR have been created label Jun 29, 2021
@6543
Copy link
Member

6543 commented Jun 29, 2021

-> #16305

zeripath pushed a commit that referenced this pull request Jun 29, 2021
end is start + pageSize and not start + page

Co-authored-by: sebastian-sauer <sauer.sebastian@gmail.com>
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
end is start + pageSize and not start + page
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
@sebastian-sauer sebastian-sauer deleted the fix_listoptions_startend branch July 9, 2023 19:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants