-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support unprotected file patterns #16395
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
added
the
type/feature
Completely new functionality. Can only be merged if feature freeze is not active.
label
Jul 10, 2021
Codecov Report
@@ Coverage Diff @@
## main #16395 +/- ##
==========================================
+ Coverage 45.21% 45.24% +0.03%
==========================================
Files 766 766
Lines 86596 86641 +45
==========================================
+ Hits 39154 39204 +50
+ Misses 41103 41093 -10
- Partials 6339 6344 +5
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Jul 11, 2021
# Conflicts: # models/migrations/migrations.go # models/migrations/v188.go
lafriks
approved these changes
Aug 10, 2021
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Aug 10, 2021
# Conflicts: # models/migrations/migrations.go # models/migrations/v191.go
# Conflicts: # models/migrations/migrations.go # models/migrations/v193.go
6543
reviewed
Sep 10, 2021
6543
approved these changes
Sep 11, 2021
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Sep 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/feature
Completely new functionality. Can only be merged if feature freeze is not active.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16381.
Note that changes to unprotected files via the web editor still cannot be pushed directly to the protected branch.
I could easily add such support for edits and deletes if needed. But for adding, uploading or renaming unprotected files, it is not trivial.