Extend the fail2ban instructions with a hint on how to make X-Real-IP… #16446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… / X-Forwarded-For headers wor
GiteaBot
added
the
lgtm/need 2
Codecov Report
@@ Coverage Diff @@
## main #16446 +/- ##
==========================================
+ Coverage 45.42% 45.45% +0.02%
==========================================
Files 717 717
Lines 84182 84182
==========================================
+ Hits 38237 38262 +25
+ Misses 39790 39775 -15
+ Partials 6155 6145 -10
Continue to review full report at Codecov.
|
dosera
force-pushed
the
add-x-forwarded-headers-documentation
branch
from
9cd7f99
to
ae56002
Compare
dosera
force-pushed
the
add-x-forwarded-headers-documentation
branch
from
ae56002
to
60c2e1e
Compare
techknowlogick
approved these changes
Jul 15, 2021
GiteaBot
added
lgtm/need 1
techknowlogick
added
type/docs
lafriks
reviewed
Jul 15, 2021
Co-authored-by: zeripath <art27@cantab.net>
zeripath
approved these changes
Jul 16, 2021
GiteaBot
added
lgtm/done
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
go-gitea#16446) Following the merging of go-gitea#14959 - Gitea is a lot more strict regarding the interpretation of `X-Real-IP` and `X-Forwarded-For` headers. This PR updates the fail2ban documentation to include hints to set: `REVERSE_PROXY_TRUSTED_PROXIES` and `REVERSE_PROXY_LIMIT` appropriately. See discussion in go-gitea#16443 Co-authored-by: zeripath <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the merging of #14959 - Gitea is a lot more strict regarding the interpretation of
X-Real-IPandX-Forwarded-Forheaders.This PR updates the fail2ban documentation to include hints to set:
REVERSE_PROXY_TRUSTED_PROXIESandREVERSE_PROXY_LIMITappropriately.See discussion in #16443