Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger API: rename repoAddTopíc to repoAddTopic #16580

Merged
merged 6 commits into from
Aug 1, 2021
Merged

Conversation

larshp
Copy link
Contributor

@larshp larshp commented Jul 30, 2021

This changes the operationId of operation "repoAddTopic" to only contain 7-bit ascii, note "i" instead of "í"

larshp added 4 commits July 30, 2021 14:53
This changes the operationId to only contain 7 bit ascii, note "í" instead of "i"
@codecov-commenter

This comment has been minimized.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 30, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 31, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 1, 2021
@techknowlogick techknowlogick added this to the 1.16.0 milestone Aug 1, 2021
@techknowlogick techknowlogick added the type/docs This PR mainly updates/creates documentation label Aug 1, 2021
@larshp
Copy link
Contributor Author

larshp commented Aug 1, 2021

After main was merged into the branch, the build fails with "TypeError: String.prototype.startsWith called on null or undefined"

This is also a problem in other PRs, so I guess there is something wrong in main?

@techknowlogick
Copy link
Member

@larshp indeed, your PR is correct. We need to resolve an unrelated issue before being able to merge your PR. Thank you for your work on this PR.

@6543 6543 merged commit d686d7b into go-gitea:main Aug 1, 2021
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
* Swagger API: rename repoAddTopíc to repoAddTopic

This changes the operationId to only contain 7 bit ascii, note "í" instead of "i"
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants