Skip to content

Conversation

n194
Copy link
Contributor

@n194 n194 commented Aug 18, 2021

This PR adds an edit button to wiki sidebars and footer

Closes #16655

@a1012112796 a1012112796 added the topic/ui Change the appearance of the Gitea UI label Aug 18, 2021
@silverwind
Copy link
Member

I think it should either be with a transparent background or with border and background (e.g. replace label with button class).

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 18, 2021
@n194
Copy link
Contributor Author

n194 commented Aug 18, 2021

@silverwind I tried it with the button class but there were some alignment/overflow issues. I can make it transparent, is there a class that I can use to revert the blue color of a link?

@silverwind
Copy link
Member

Yes, add muted class to the <a>.

@n194
Copy link
Contributor Author

n194 commented Aug 18, 2021

Fixed
screenshot

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2021

Codecov Report

Merging #16719 (213a856) into main (9f0c8f9) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16719      +/-   ##
==========================================
- Coverage   45.36%   45.35%   -0.01%     
==========================================
  Files         760      760              
  Lines       85482    85482              
==========================================
- Hits        38775    38774       -1     
- Misses      40424    40426       +2     
+ Partials     6283     6282       -1     
Impacted Files Coverage Δ
services/pull/temp_repo.go 30.76% <0.00%> (-3.85%) ⬇️
services/pull/check.go 25.51% <0.00%> (-2.76%) ⬇️
services/pull/patch.go 54.23% <0.00%> (-1.70%) ⬇️
routers/web/repo/view.go 40.95% <0.00%> (-0.58%) ⬇️
services/pull/pull.go 41.78% <0.00%> (ø)
services/gitdiff/gitdiff.go 74.23% <0.00%> (+0.97%) ⬆️
modules/log/event.go 62.50% <0.00%> (+1.85%) ⬆️
modules/charset/charset.go 73.73% <0.00%> (+2.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f0c8f9...213a856. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 18, 2021
@lafriks lafriks added this to the 1.16.0 milestone Aug 18, 2021
@silverwind
Copy link
Member

silverwind commented Aug 18, 2021

BTW we really need to add some UI later to create sidebar and footer.

Edit, see: #16655

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 18, 2021
@techknowlogick techknowlogick merged commit 4aa3cac into go-gitea:main Aug 18, 2021
@n194 n194 deleted the wiki-edit-button branch August 19, 2021 04:18
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit wiki sidebar via UI
8 participants