Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes username tagging in "Reference in new issue" #17074

Merged
merged 3 commits into from
Sep 18, 2021

Conversation

MrGussio
Copy link
Contributor

@MrGussio MrGussio commented Sep 17, 2021

Adds an extra attribute to every issue comment containing the actual username, such that it can be used to tag the original author when clicking on "Reference in new issue" (#17073)

Fix #17073

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 17, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 18, 2021
@a1012112796 a1012112796 added the topic/ui Change the appearance of the Gitea UI label Sep 18, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #17074 (f33edbe) into main (8fb3a50) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17074      +/-   ##
==========================================
- Coverage   45.26%   45.25%   -0.01%     
==========================================
  Files         771      771              
  Lines       86767    86767              
==========================================
- Hits        39271    39267       -4     
- Misses      41145    41148       +3     
- Partials     6351     6352       +1     
Impacted Files Coverage Δ
modules/git/repo_base_nogogit.go 82.85% <0.00%> (-2.86%) ⬇️
modules/git/utils.go 68.05% <0.00%> (-2.78%) ⬇️
modules/queue/workerpool.go 50.00% <0.00%> (-1.15%) ⬇️
models/repo_list.go 77.64% <0.00%> (-0.79%) ⬇️
models/issue_comment.go 51.17% <0.00%> (-0.59%) ⬇️
services/pull/pull.go 42.19% <0.00%> (+0.40%) ⬆️
modules/log/file.go 75.20% <0.00%> (+1.60%) ⬆️
modules/charset/charset.go 75.75% <0.00%> (+4.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fb3a50...f33edbe. Read the comment docs.

@zeripath zeripath merged commit b74a0f9 into go-gitea:main Sep 18, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
@wxiaoguang wxiaoguang added this to the 1.16.0 milestone Nov 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Reference in new issue" original-poster tagging not working
7 participants