Skip to content

Conversation

@ForestJohnson
Copy link
Contributor

Just a tiny change to save someone some time while reading the docs. I got lost in the angular code and npm packages trying to reverse engineer it and figure out what setting controlled this file limit:

image

Eventually I tracked it down from

file_too_big = File size ({{filesize}} MB) exceeds the maximum size of ({{maxFilesize}} MB).

to

data-file-too-big="{{.i18n.Tr "dropzone.file_too_big"}}"

to

dictFileTooBig: $dropzone.data('file-too-big'),

to

import(/* webpackChunkName: "dropzone" */'dropzone'),

to

https://www.npmjs.com/package/dropzone

and then I realized I can't read 😅, back to

data-max-size="{{.UploadMaxSize}}"

and quickly solved it from there!!

ctx.Data["UploadMaxSize"] = setting.Attachment.MaxSize

Yes I know this long path was 90% me failing to read code properly and going on a red herring journey... but point is we should not have to do this in the first place to know how to configure this file upload form 🥺 👉 👈

@techknowlogick techknowlogick added the type/docs This PR mainly updates/creates documentation label Sep 27, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 27, 2021
@wxiaoguang
Copy link
Contributor

Should the section ## Issue and pull request attachments (attachment) be renamed to ## Issue, pull request and release attachments (attachment)?

@delvh
Copy link
Member

delvh commented Sep 27, 2021

Should the section ## Issue and pull request attachments (attachment) be renamed to ## Issue, pull request and release attachments (attachment)?

While I generally agree with that, I would maybe not use this attachment duplication, so that the following would be the new title:
## Issue, pull request and release attachments.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 27, 2021
@zeripath
Copy link
Contributor

make lgtm work

@zeripath zeripath merged commit 868e937 into go-gitea:main Sep 27, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants