-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add protection to disable Gitea when run as root #17168
Merged
6543
merged 17 commits into
go-gitea:main
from
techknowlogick:please-dont-run-as-root-i-beg-of-you
Oct 7, 2021
Merged
Changes from 11 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
9137b0c
Add protection to disable Gitea when run as root
techknowlogick 9834049
placate lint
techknowlogick 4c6e567
woops, this isn't an exsting var
techknowlogick 4e601f2
Merge branch 'main' into please-dont-run-as-root-i-beg-of-you
techknowlogick 45db44c
Update modules/setting/setting.go
techknowlogick 8c3c6d6
Update modules/setting/setting.go
techknowlogick cbe7f2e
update drone to use non-root user
techknowlogick 79dc6b9
Merge branch 'main' into please-dont-run-as-root-i-beg-of-you
techknowlogick 717f54c
not all steps have custom image
techknowlogick e7a4c38
Merge branch 'please-dont-run-as-root-i-beg-of-you' of github.com:tec…
techknowlogick ad3c03e
not all steps have custom image
techknowlogick c06e58a
Merge branch 'main' into please-dont-run-as-root-i-beg-of-you
6543 3b8dbf6
Merge branch 'main' into please-dont-run-as-root-i-beg-of-you
6543 4fd6aa3
Critical
6543 5868169
use uid
6543 eb17ed1
Merge branch 'main' into please-dont-run-as-root-i-beg-of-you
techknowlogick 9584001
add "fix-permissions"
6543 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we guarantee for every supported OS that the root account will be called "root"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't entirely (Windows is the case where it is certain to not be "root"), however windows is out of scope of this PR. This purpose of this PR wasn't to be exhaustive of all the possibilities, just to prevent me from being lazy and running things as root where I could mess up file permissions 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd stick a GOOS check here and exclude dozers from this check.
Then just use os.GetUID() == 0 instead of checking username.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we dont need to check goos on windows we will get a -1