Update documents for Gitea behind reverse proxy. Fix some small bugs (some URLs are generated without sub-path) #17320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd URI headers on HTTP redirect responses, it causes more problems than it resolves. Now all URLs generated by Gitee have the correct prefix AppSubURL. We do not need to set `ProxyPassReverse`.
wxiaoguang
added
type/bug
type/docs
zeripath
approved these changes
Oct 15, 2021
GiteaBot
added
the
lgtm/need 1
delvh
reviewed
Oct 15, 2021
Codecov Report
@@ Coverage Diff @@
## main #17320 +/- ##
=======================================
Coverage 45.27% 45.28%
=======================================
Files 781 781
Lines 87974 87974
=======================================
+ Hits 39834 39841 +7
+ Misses 41669 41664 -5
+ Partials 6471 6469 -2
Continue to review full report at Codecov.
|
delvh
approved these changes
Oct 15, 2021
GiteaBot
added
lgtm/done
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
…(some URLs are generated without sub-path) (go-gitea#17320) * Apache `ProxyPassReverse` only works for Location, Content-Location and URI headers on HTTP redirect responses, it causes more problems than it resolves. Now all URLs generated by Gitee have the correct prefix AppSubURL. We do not need to set `ProxyPassReverse`. * fix url param * use AppSubURL instead of AppURL in api/v1 Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many people meet problems when they try to setup Gitea in a sub-path behind a reverse proxy ( #17310 , and some chats in discord channels)
The fact is: Apache
ProxyPassReverseonly works for Location, Content-Location andd URI headers on HTTP redirect responses, it causes more problems than it resolves. Now all URLs generated by Gitee have the correct prefix AppSubURL. We do not need to setProxyPassReverse.So the PR updates the document and fix some small bugs (some URLs are generated without sub-path).