Fix stats upon searching issues (#17566) #17578
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #17566
thus the returned results where not the correct results. More specifically when the amount of returned results are above
maxQueryParameters
.To reproduce this issue easily:
maxQueryParameters
within the code to a value of5
.Hello
).Hello
.^ This PR fixes that issue.
Their is a interesting comment above the relevant code:
gitea/models/issue.go
Lines 1502 to 1505 in bd613c7
I do think that the person writing that comment was hitting into this bug whereby the wrong issuesIDs were used in the database action and I do think it can be removed, but I'm not sure.
Screenshots(The repo had 7 issues with the description of
Helo
):Before:
After: