Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint and document manager api #176

Merged
merged 1 commit into from
Nov 24, 2016
Merged

Conversation

strk
Copy link
Member

@strk strk commented Nov 15, 2016

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 15, 2016

Current coverage is 3.03% (diff: 100%)

Merging #176 into master will not change coverage

@@            master      #176   diff @@
========================================
  Files           33        33          
  Lines         8107      8107          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           246       246          
  Misses        7841      7841          
  Partials        20        20          

Powered by Codecov. Last update 6ed7f26...ad3d6b7

@tboerger
Copy link
Member

There is already a pr that updates it heavily?

@lunny
Copy link
Member

lunny commented Nov 15, 2016

this PR will be conflicted with #75.

@strk
Copy link
Member Author

strk commented Nov 15, 2016

#75 is targetted at 1.1.0 and currently blocked

@tboerger
Copy link
Member

You have set it to 1.1, it was set to 1.0

@strk
Copy link
Member Author

strk commented Nov 15, 2016

Oh, I did. It was a WIP and I thought we were going to release 1.0.0 with the least change to allow for upgrades. If it's ready to merge and you think it is safe then change it back (I cannot modify milestones anymore).
Once again, this PR is smaller in scope.

@lunny
Copy link
Member

lunny commented Nov 17, 2016

Golint fixed is always welcome. Since both sdk and git are Golint OK. I think we could fix this repo's Golint problems before v1.0.0.
So let's see #75's progress to decide how to resovle this one.

@strk
Copy link
Member Author

strk commented Nov 19, 2016

#75 by @metalmatze is blocked on drone availability, for which a PR also by @metalmatze exists (#96)

Does it really make sense to wait on all these semaphores rather than merging small PRs ?

@lunny
Copy link
Member

lunny commented Nov 24, 2016

So let's LGTM this and let #75 rebase.

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 24, 2016
@lunny lunny added this to the 1.0.0 milestone Nov 24, 2016
@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 24, 2016
@tboerger
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 24, 2016
@tboerger tboerger merged commit 0581210 into go-gitea:master Nov 24, 2016
@strk strk deleted the manager-lint branch November 24, 2016 10:46
@lunny
Copy link
Member

lunny commented Nov 28, 2016

resolved #70

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/code-linting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants