Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move unit_tests into unittest package #17633

Closed
wants to merge 3 commits into from
Closed

Move unit_tests into unittest package #17633

wants to merge 3 commits into from

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 13, 2021

As title.

wxiaoguang
wxiaoguang reviewed Nov 13, 2021
View reviewed changes
models/consistency.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 13, 2021
@wxiaoguang
Copy link
Contributor

Cool 👍. Since checkConsistency* are clear now, in next PR we can remove the intermediate unittestbridge

@lunny lunny added the pr/wip This PR is not ready for review label Nov 14, 2021
@wxiaoguang wxiaoguang mentioned this pull request Nov 16, 2021
Merged
@lunny lunny closed this Nov 16, 2021
@lunny lunny deleted the lunny/move_unittests branch November 16, 2021 07:23
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. pr/wip This PR is not ready for review type/testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lunny @wxiaoguang @GiteaBot