Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix database deadlock when update issue labels (#17649) #17665

Merged
merged 2 commits into from
Nov 17, 2021
Merged

Fix database deadlock when update issue labels (#17649) #17665

merged 2 commits into from
Nov 17, 2021

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Nov 16, 2021 •
edited
Loading

Backport #17649.

This fix updates issue labels one by one, and won't cause database deadlock.

In future, we can use a batch API (in 1.16 or later) to update all changed labels by one request.

For 1.15, this fix seems enough.

@wxiaoguang wxiaoguang added type/bug topic/ui Change the appearance of the Gitea UI labels Nov 16, 2021
@wxiaoguang wxiaoguang added this to the 1.15.7 milestone Nov 16, 2021
@wxiaoguang wxiaoguang linked an issue Nov 16, 2021 that may be closed by this pull request
Batch calling of updateIssuesMeta causes database deadlock #17469
Closed
@Gusted
Copy link
Contributor

Gusted commented Nov 16, 2021

CI failing is fixed by #17668

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 16, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 16, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 16, 2021
@lunny
Copy link
Member

lunny commented Nov 17, 2021

make L-G-T-M work.

@lunny lunny merged commit 6cd1cce into go-gitea:release/v1.15 Nov 17, 2021
@wxiaoguang wxiaoguang deleted the backport-update-issue-label branch November 17, 2021 09:57
@zeripath zeripath changed the title Backport #17649, fix database deadlock when update issue labels Fix database deadlock when update issue labels (#17649) Nov 17, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gusted Gusted Gusted approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.15.7
Development

Successfully merging this pull request may close these issues.

Batch calling of updateIssuesMeta causes database deadlock
5 participants
@wxiaoguang @Gusted @lunny @silverwind @GiteaBot