Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move task from modules to services #17680

Merged
merged 3 commits into from
Nov 18, 2021
Merged

Move task from modules to services #17680

merged 3 commits into from
Nov 18, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 17, 2021

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 17, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 17, 2021
@lunny lunny force-pushed the lunny/move_task_service branch from dc6dddd to 4a5e761 Compare November 17, 2021 16:03
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@3c3855a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #17680   +/-   ##
=======================================
  Coverage        ?   45.49%           
=======================================
  Files           ?      800           
  Lines           ?    89228           
  Branches        ?        0           
=======================================
  Hits            ?    40595           
  Misses          ?    42100           
  Partials        ?     6533
Impacted Files Coverage Δ
routers/init.go 80.80% <ø> (ø)
routers/web/repo/migrate.go 36.25% <ø> (ø)
services/task/migrate.go 36.36% <ø> (ø)
services/task/task.go 59.70% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c3855a...52efa7b. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 18, 2021
@lunny lunny merged commit 1f1ae57 into go-gitea:main Nov 18, 2021
@lunny lunny deleted the lunny/move_task_service branch November 18, 2021 06:48
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@lunny
Move task from modules to services (go-gitea#17680)
91776c9
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @codecov-commenter @lafriks @wxiaoguang @GiteaBot