Fix close issue but time watcher still running (#17643) #17761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gusted
approved these changes
Nov 22, 2021
GiteaBot
added
the
lgtm/need 1
zeripath
suggested changes
Nov 22, 2021
Co-authored-by: zeripath <art27@cantab.net>
|
@zeripath done. |
|
Do we need to fix main too? |
zeripath
approved these changes
Nov 23, 2021
GiteaBot
added
lgtm/done
|
There are many ways in which races resulting in a double stopwatches could still happen here. Realistically the decision to finish or open a new stopwatch should be done within a transaction with select for updates etc. However this is a backport and this is just yet another example of easily induceable inconsistency under load. We have to address this at some point though. |
zeripath
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
back port from #17643