Skip to content

Fix svg colors in file list table #17903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 4, 2021
Merged

Fix svg colors in file list table #17903

merged 3 commits into from
Dec 4, 2021

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Dec 4, 2021 •
edited
Loading

Fixes #17897 (comment).

Turns out this can be fixed by just removing rules. Directory and file icons have other rules that still make them color correctly.

image

image

@silverwind
Fix svg colors in file list table
3b8c743 
Turns out this can be fixed by just removing rules. Directory and file
icons have other rules that still make them color correctly.
@silverwind silverwind mentioned this pull request Dec 4, 2021
Merged
@silverwind silverwind added the topic/ui Change the appearance of the Gitea UI label Dec 4, 2021
@silverwind
Copy link
Member Author

Small tweak done on the color of file icons:

image

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 4, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 4, 2021
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Dec 4, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 4, 2021
@lunny
Copy link
Member

lunny commented Dec 4, 2021

make L-G-T-M work

@lunny lunny merged commit 8d85a62 into go-gitea:main Dec 4, 2021
@silverwind silverwind deleted the iconcolor branch December 4, 2021 13:19
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@silverwind @wxiaoguang
Fix svg colors in file list table (go-gitea#17903)
3048802 
* Fix svg colors in file list table

Turns out this can be fixed by just removing rules. Directory and file
icons have other rules that still make them color correctly.

* tweak color on file icons

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@silverwind @lunny @wxiaoguang @GiteaBot