-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor HTTP request context #17979
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
added
the
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
label
Dec 14, 2021
KN4CK3R
reviewed
Dec 14, 2021
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Dec 14, 2021
CI failure is not related. Other passed PRs also have such failure:
|
KN4CK3R
approved these changes
Dec 14, 2021
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Dec 14, 2021
lunny
approved these changes
Dec 15, 2021
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Dec 15, 2021
wxiaoguang
added
the
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
label
Dec 15, 2021
Codecov Report
@@ Coverage Diff @@
## main #17979 +/- ##
=======================================
Coverage ? 45.28%
=======================================
Files ? 820
Lines ? 90930
Branches ? 0
=======================================
Hits ? 41174
Misses ? 43195
Partials ? 6561
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
I was working on some new enhancements, while I found the modules/context/context.go is quite messy, so I think it's better to refactor first before other works.
Major Changes
HTMLString(name string, data interface{})
=>RenderToString(name base.TplName, data map[string]interface{})
, the first paramter is aTplName
, and the oldHTMLString
naming conflicts with other function names likeHTML
/PlainText
TmplLoadTimes
is reworked. The oldTmplLoadTimes
in oldHTMLString
has no effects because the render doesn't usectx.Data
NotFound(title string, err error)
andServerError(title string, err error)
related functions are refactored, because thetitle
is not title, it only appears in log.PlainText(string)
andPlainTextBytes([]byte)
to replace oldPlainText([]bytes)
andHandleText(string)
SignedUserName
type contextKeyType struct{}; var contextKey interface{} = contextKeyType{}
to replacevar contextKey interface{} = "default_context"
ctx.RespHeader()
to replacectx.Header()
, becausectx.Header()
is not clear whether it is for request or response.