Skip to content

Fix rename notification bug #18008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 17, 2021
+4 −2
Merged

Fix rename notification bug #18008

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b15a3ef
Fix rename notification bug
lunny Dec 17, 2021
c06db14
Update services/repository/transfer.go
zeripath Dec 17, 2021
c8a2bbb
Merge branch 'main' into lunny/fix_notification_bug
zeripath Dec 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions modules/notification/action/action.go
View file
Original file line number Diff line number Diff line change
@@ -152,8 +152,6 @@ func (a *actionNotifier) NotifyNewPullRequest(pull *models.PullRequest, mentions
}

func (a *actionNotifier) NotifyRenameRepository(doer *user_model.User, repo *repo_model.Repository, oldRepoName string) {
log.Trace("action.ChangeRepositoryName: %s/%s", doer.Name, repo.Name)

if err := models.NotifyWatchers(&models.Action{
ActUserID: doer.ID,
ActUser: doer,
4 changes: 4 additions & 0 deletions services/repository/transfer.go
View file
Original file line number Diff line number Diff line change
@@ -12,6 +12,7 @@ import (
"code.gitea.io/gitea/models/perm"
repo_model "code.gitea.io/gitea/models/repo"
user_model "code.gitea.io/gitea/models/user"
"code.gitea.io/gitea/modules/log"
"code.gitea.io/gitea/modules/notification"
"code.gitea.io/gitea/modules/sync"
)
@@ -57,6 +58,8 @@ func TransferOwnership(doer, newOwner *user_model.User, repo *repo_model.Reposit

// ChangeRepositoryName changes all corresponding setting from old repository name to new one.
func ChangeRepositoryName(doer *user_model.User, repo *repo_model.Repository, newRepoName string) error {
log.Trace("ChangeRepositoryName: %s/%s -> %s", doer.Name, repo.Name, newRepoName)

oldRepoName := repo.Name

// Change repository directory name. We must lock the local copy of the
@@ -70,6 +73,7 @@ func ChangeRepositoryName(doer *user_model.User, repo *repo_model.Repository, ne
}
repoWorkingPool.CheckOut(fmt.Sprint(repo.ID))

repo.Name = newRepoName
notification.NotifyRenameRepository(doer, repo, oldRepoName)

return nil