Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 500 for GET /teams/:id endpoints #1811

Merged
merged 3 commits into from
May 26, 2017

Conversation

ethantkoenig
Copy link
Member

@ethantkoenig ethantkoenig commented May 25, 2017

Fixes #1809. Also adds an integration test for the fixed endpoint.

@ethantkoenig ethantkoenig mentioned this pull request May 25, 2017
7 tasks
@lunny lunny added modifies/api This PR adds API routes or modifies them type/bug labels May 26, 2017
@lunny lunny added this to the 1.2.0 milestone May 26, 2017
)

func TestAPITeam(t *testing.T) {
assert.NoError(t, models.LoadFixtures())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prepareTestEnv is better

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@lunny
Copy link
Member

lunny commented May 26, 2017

Otherwise LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 26, 2017
@sapk
Copy link
Member

sapk commented May 26, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 26, 2017
@appleboy appleboy merged commit 7e6ff69 into go-gitea:master May 26, 2017
@ethantkoenig ethantkoenig deleted the fix_team_api branch May 27, 2017 03:03
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API : teams query
5 participants