-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add packagist webhook #18224
Add packagist webhook #18224
Conversation
Codecov Report
@@ Coverage Diff @@
## main #18224 +/- ##
==========================================
+ Coverage 45.74% 46.04% +0.29%
==========================================
Files 831 839 +8
Lines 92178 92543 +365
==========================================
+ Hits 42171 42613 +442
+ Misses 43249 43155 -94
- Partials 6758 6775 +17
Continue to review full report at Codecov.
|
I've been waiting for this for quite some time, great work, thank you so much! |
models/migrations/v161.go
Outdated
@@ -22,6 +22,7 @@ func convertTaskTypeToString(x *xorm.Engine) error { | |||
FEISHU | |||
MATRIX | |||
WECHATWORK | |||
PACKAGIST |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here and below and v162.go, the PACKAGIST
doesn't need to be processed. At that time we did not have it yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your review and the approval. I've removed the migrations from v161.go and v162.go.
I had already suspected that those migrations are not necessary, but I've looked at the PR for the last webhook addition (wechatnetwork, #15910). In that PR, those migrations have been added. AFAIU, the migrations for WeChat were not necessary either, right?
I've also merged in the latest changes from the gitea main branch and squashed the commits, to keep the commit for this PR as minimal as possible. If you'd like to have separate commits, please say so, and I'll force-push again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yep, adding or not are both fine .... just small nit, nvm. I didn't review the wechatnetwork PR #15910 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once this in the a released stable version we might want to add a notice to the packagist site: https://github.com/composer/packagist https://packagist.org/about under How to update packages?
Thanks for your approval. Yes, adding instructions for gitea on the packagist.org website is definitely useful. I'll try to remember sending them a PR when gitea has been released with this webhook. 😄 |
@wxiaoguang Should I squash the commits again, rebase and force-push my branch? |
No need. Squash merge works well in GitHub, just wait for the CI to pass 😊 |
* 'main' of https://github.com/go-gitea/gitea: Add packagist webhook (go-gitea#18224) Fix mime-type detection for HTTP server (go-gitea#18370) Always use git command but not os.Command (go-gitea#18363) Add deprecated for LFS_CONTENT_PATH on zh-cn docs (go-gitea#18362) [skip ci] Updated translations via Crowdin Make gitea, gitea-vet future-proof (go-gitea#18361) Pause queues (go-gitea#15928) Disable content sniffing on `PlainTextBytes` (go-gitea#18359) Update github.com/duo-labs/webauthn (go-gitea#18357)
Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Hi,
this PR adds a new webhook for Packagist integration.
Packagist is the main Composer repository. It aggregates public PHP packages installable with Composer.
Using the webhook in a repository, a PHP package hosted on a gitea server will automatically update its information on packagist.org on push events.
I've built gitea on my machine and tested the new webhook locally. Everything seems to work as expected.
Regards,
Tobias