Change initial TrustModel to committer #18335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current default trustmodel for gitea is the collaborator model. This is not GitHub compatible by default. Now changing the nil default model committer would be a breaking change and could cause commits to become unverified. Therefore we should change the install default to committer so that new users have the github default model and later make a breaking change to set the default to committer. Related go-gitea#18328 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
the
pr/breaking
techknowlogick
approved these changes
Jan 20, 2022
GiteaBot
added
the
lgtm/need 1
lunny
approved these changes
Jan 20, 2022
GiteaBot
added
lgtm/done
zjjhot
pushed a commit
to zjjhot/gitea
that referenced
this pull request
Jan 20, 2022
* 'main' of https://github.com/go-gitea/gitea: Change initial TrustModel to committer (go-gitea#18335) refactor httplib (go-gitea#18338) Propagate context and ensure git commands run in request context (go-gitea#17868) Upgrade Alpine from 3.13 to 3.15 (go-gitea#18050) [skip ci] Updated translations via Crowdin Stop trimming preceding and suffixing spaces from editor filenames (go-gitea#18334) [skip ci] Updated translations via Crowdin Left-Align text in Unicode warning boxes (go-gitea#18331) Only warn on bidi but still escape non-bidi (go-gitea#18333) Fix incorrect OAuth message (go-gitea#18332) [skip ci] Updated translations via Crowdin Changelog for 1.16.0-rc1 (go-gitea#18309)
Closed
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current default trustmodel for gitea is the collaborator model. This is not GitHub
compatible by default. Now changing the nil default model committer would be a breaking
change and could cause commits to become unverified. Therefore we should change the
install default to committer so that new users have the github default model and
later make a breaking change to set the default to committer.
Related #18328
Signed-off-by: Andrew Thornton art27@cantab.net