Skip to content

Use next gen codecov uploader #18443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 30, 2022
Merged

Use next gen codecov uploader #18443

merged 5 commits into from
Jan 30, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented Jan 29, 2022 •
edited
Loading

current plugin do use https://github.com/codecov/codecov-bash witch will stop working on On February 1, 2022

@6543 6543 added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Jan 29, 2022
@techknowlogick
Copy link
Member

Does anyone of us use the codecov report? Maybe we should remove it instead? Cc: @go-gitea/owners

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 29, 2022
@lunny
Copy link
Member

lunny commented Jan 29, 2022 •
edited
Loading

It will not work after we move to gitea.com and I have sent email to codecov to ask them to support Gitea but they rejected that time.

@codecov-commenter
Copy link

Codecov Report

Merging #18443 (8b6f972) into main (3349fd8) will increase coverage by 0.23%.
The diff coverage is 40.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18443      +/-   ##
==========================================
+ Coverage   46.03%   46.27%   +0.23%     
==========================================
  Files         840      842       +2     
  Lines       92856   121156   +28300     
==========================================
+ Hits        42746    56062   +13316     
- Misses      43323    58290   +14967     
- Partials     6787     6804      +17
Impacted Files Coverage Δ
cmd/restore_repo.go 0.00% <0.00%> (ø)
models/auth/twofactor.go 20.27% <0.00%> (-1.27%) ⬇️
models/db/engine.go 33.55% <ø> (-2.58%) ⬇️
models/issue_milestone.go 67.62% <ø> (-2.73%) ⬇️
modules/generate/generate.go 0.00% <0.00%> (ø)
modules/indexer/code/elastic_search.go 1.12% <0.00%> (-0.50%) ⬇️
modules/migration/issue.go 100.00% <ø> (ø)
modules/private/restore_repo.go 0.00% <0.00%> (ø)
modules/queue/queue.go 35.82% <0.00%> (-1.28%) ⬇️
modules/queue/setting.go 21.59% <0.00%> (-2.74%) ⬇️
... and 837 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 726715f...8b6f972. Read the comment docs.

@6543 6543 changed the title [WIP] use next gen codecov uploader Use next gen codecov uploader Jan 29, 2022
@6543 6543 marked this pull request as ready for review January 29, 2022 04:46
@6543
Copy link
Member Author

6543 commented Jan 29, 2022

I would say with switching to gitea.com - we should switch to a self-hosted code coverage explorer ... there exist some but i did not test them

@lunny
Copy link
Member

lunny commented Jan 29, 2022

But he recommend https://github.com/codecov/uploader ?

@6543
Copy link
Member Author

6543 commented Jan 29, 2022

yes https://github.com/woodpecker-ci/plugin-codecov is exact that just a wrapper to be a plugin for drone/woodpecker

@silverwind
Copy link
Member

silverwind commented Jan 29, 2022 •
edited
Loading

Why even have a external service like this? For example with jest, one can just do a text-only output of the coverage report, which works offline as well as directly in the CI. I think it's better to not depend on an external service.

move to gitea.com

What's the plan here? I think it's better to stay on GH for the overall project health.

@lunny
Copy link
Member

lunny commented Jan 29, 2022

Why even have a external service like this? For example with jest, one can just do a text-only output of the coverage report, which works offline as well as directly in the CI. I think it's better to not depend on an external service.

move to gitea.com

What's the plan here? I think it's better to stay on GH for the overall project health.

The first big stage is Gitea hosted Gitea.

@6543
Copy link
Member Author

6543 commented Jan 29, 2022 •
edited
Loading

https://alternativeto.net/software/codecov-io/?platform=self-hosted
-> https://github.com/danhper/opencov

but it does not have diagrams ...

zeripath
zeripath approved these changes Jan 29, 2022
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think codecov could still be useful - but equally I don't particularly use the reports.

I'm gonna approve this because if we don't do this this drone step will fail and break all of our CI in 2 days time.

However, I would equally consider approving a PR that removed it.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 29, 2022
@zeripath
Copy link
Contributor

We'll need backports of this or the removal PRs too. So we need to get a decision in in the next 2 days.

techknowlogick
techknowlogick approved these changes Jan 29, 2022
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to what zeripath said. I don't use this, but would prefer our builds don't break. Let's discuss future options for either removing or using a different service elsewhere

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 29, 2022
@6543
Copy link
Member Author

6543 commented Jan 30, 2022 •
edited
Loading

I'll remove it on the release branches (v1.16 & v1.15) ... - and will merge this - we should talk about what's next ... once backports done I'll open an issue for it

@6543
Copy link
Member Author

6543 commented Jan 30, 2022

🚀

@6543 6543 merged commit 246902c into go-gitea:main Jan 30, 2022
@6543 6543 deleted the codecov_new-plugin branch January 30, 2022 02:21
@6543
Copy link
Member Author

6543 commented Jan 30, 2022

PS: we dont need to remove it in release branches -> because it get skiped:

    when:
      branch:
        - main
      event:
        - push
        - pull_request

@6543 6543 mentioned this pull request Jan 30, 2022
Closed
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 12, 2022
@6543 @silverwind
use next gen codecov uploader (go-gitea#18443)
bd6ea6d
@silverwind silverwind mentioned this pull request Feb 12, 2022
Merged
zeripath pushed a commit that referenced this pull request Feb 12, 2022
@silverwind @6543 @techknowlogick
Reduce CI go module downloads, add make targets (#18708, #18475, #18443…
c04a4af 
…) (#18741)

Backport #18708 
Backport #18475 
Backport #18443 

The CI currently downloads all go modules in each pipeline step because go modules reside outside the project directory. Fix this by introducing a volume for the `/go` directory [1] so modules are only downloaded once per pipeline using a new `deps-backend` make target.

For completeness, I also included new `deps` and `deps-frontend` targets and the frontend one is also triggered explicitly on CI where needed.

[1] https://docs.drone.io/pipeline/kubernetes/examples/language/golang/#dependencies

* Also backports #18475 and #18443 so that is was able to merge cleanly.
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@zeripath zeripath added backport/done All backports for this PR have been created backport/v1.16 labels Feb 12, 2022
@zeripath zeripath added this to the 1.17.0 milestone Feb 12, 2022
@6543
Copy link
Member Author

6543 commented Feb 25, 2022

@masstez ?

Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@6543
use next gen codecov uploader (go-gitea#18443)
39c7954
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
7 participants
@6543 @techknowlogick @lunny @codecov-commenter @silverwind @zeripath @GiteaBot