Fix some mirror bugs #18649
Merged
Fix some mirror bugs #18649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
reviewed
Feb 7, 2022
GiteaBot
added
the
lgtm/need 2
lunny
force-pushed
the
lunny/fix_mirror
branch
from
89c748c
to
a7309af
Compare
wxiaoguang
reviewed
Feb 7, 2022
zeripath
reviewed
Feb 7, 2022
zeripath
reviewed
Feb 7, 2022
lunny
force-pushed
the
lunny/fix_mirror
branch
2 times, most recently
from
8391deb
to
e04309a
Compare
6543
reviewed
Apr 30, 2022
wxiaoguang
approved these changes
May 16, 2022
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
May 16, 2022
zeripath
reviewed
May 16, 2022
zeripath
reviewed
May 16, 2022
zeripath
reviewed
May 16, 2022
| return nil, err | ||
| } | ||
| return &GitURL{URL: u}, nil | ||
| } else if strings.Contains(remote, "@") && strings.Contains(remote, ":") { |
There was a problem hiding this comment.
The SCP target path parsing is found here: https://github.com/openssh/openssh-portable/blob/16ea8b85838dd7a4dbeba4e51ac4f43fd68b1e5b/misc.c#L767-L834
- If there is a
'['then we can split by the first':'after']'- note this
':'has to be immediately after the]otherwise the whole parse fails and it's a path.
- note this
- Otherwise split by the first
':' - We split by this
':'into<host_user> ':' <path>- if
<path>is empty set to".". If no':'set all to<path>
- if
- Split
<host_user>by'@'into<user> '@' <host-to-clean>.- if no
'@'set all to<host-to-clean>
- if no
<host-to-clean>- strip off'['and']'if present to form the<host>
zeripath
approved these changes
Jun 11, 2022
GiteaBot
added
lgtm/done
|
make L-G-T-M work |
|
Removed backport because the changes too big to cherry pick. |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 12, 2022
* giteaoffical/main: Fix signal loop in graceful manager (go-gitea#19943) Prettify number of issues (go-gitea#17760) Improve file header on mobile (go-gitea#19945) Unify repo settings & show better error (go-gitea#19828) [skip ci] Updated translations via Crowdin fixed comment typo (go-gitea#19944) Auto merge pull requests when all checks succeeded via WebUI (go-gitea#19648) Fix some mirror bugs (go-gitea#18649)
mohsek
reviewed
Jun 13, 2022
Comment on lines
+977
to
+979
| if !m.IsMirror { | ||
| return a | ||
| } |
There was a problem hiding this comment.
@lunny I saw an issue here, the push mirrors URL are no longer displayed on the UI
I think we should return empty remoteAddress when the repo is a mirror not the opposite
if m.IsMirror {
return a
}
This was referenced Jun 17, 2022
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
* Fix some mirror bugs * Remove unnecessary code * Fix lint * rename stdard url * Allow more charactors in git ssh protocol url * improve the detection * support ipv6 for git url parse * Fix bug * Fix template * Fix bug * fix template * Fix tmpl * Fix tmpl * Fix parse ssh with interface * Rename functions name Co-authored-by: zeripath <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new git URL parse package to parse git URL.
It will fix mirror repository UI display problem.
Fix #18652