Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential assignee query for repo #18994

Merged
merged 4 commits into from
Mar 4, 2022
Merged

Fix potential assignee query for repo #18994

merged 4 commits into from
Mar 4, 2022

Conversation

fnetX
Copy link
Contributor

@fnetX fnetX commented Mar 3, 2022

Fix #18992

@fnetX
Copy link
Contributor Author

fnetX commented Mar 3, 2022

@zeripath I think you should check this.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 3, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 3, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 3, 2022
@Gusted
Copy link
Contributor

Gusted commented Mar 3, 2022

Time to add a test for this function? 😅

@fnetX
Copy link
Contributor Author

fnetX commented Mar 3, 2022

If someone would like to assist me there, I'm not yet familiar with the test system for Gitea ...

Gusted pushed a commit to Gusted/gitea that referenced this pull request Mar 3, 2022
Add tests for GetRepoAssignees
719e2ef 
- As per go-gitea#18994 (comment)
@Gusted
Copy link
Contributor

Gusted commented Mar 3, 2022 •
edited
Loading

@fnetX https://github.com/fnetX/gitea/pull/3 The code should be relatively self-explanatory. The "mocked" database files are loaded from models/fixtures/<table_name>.yml, I've chosen for Repo 21 explicitly as there are 2 collaborates with write access added via models/fixtures/collaboration.yml so that should avoid regression for that part(not for the team part...)

@6543 6543 added the type/bug label Mar 4, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@3c72016). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #18994   +/-   ##
=======================================
  Coverage        ?   46.59%           
=======================================
  Files           ?      854           
  Lines           ?   122819           
  Branches        ?        0           
=======================================
  Hits            ?    57227           
  Misses          ?    58676           
  Partials        ?     6916
Impacted Files Coverage Δ
models/repo.go 53.36% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c72016...1c4115e. Read the comment docs.

@lunny lunny added backport/v1.16 skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Mar 4, 2022
@lunny lunny added this to the 1.17.0 milestone Mar 4, 2022
@lunny
Copy link
Member

lunny commented Mar 4, 2022

wait https://github.com/fnetX/gitea/pull/3

@Gusted
Copy link
Contributor

Gusted commented Mar 4, 2022

@lunny has been merged.

@fnetX fnetX mentioned this pull request Mar 4, 2022
Merged
lunny pushed a commit that referenced this pull request Mar 4, 2022
@fnetX
Fix potential assignee query for repo (#18994) (#18999)
da985b2 
* Fix potential assignee query for repo

* Add tests for `GetRepoAssignees`

- As per #18994 (comment)

Co-authored-by: Gusted <williamzijl7@hotmail.com>
@lunny lunny added the backport/done All backports for this PR have been created label Mar 4, 2022
@zeripath
Copy link
Contributor

zeripath commented Mar 4, 2022

make lgtm work

@zeripath zeripath merged commit e46a8c9 into go-gitea:main Mar 4, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 6, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
26c0a78 
* giteaofficial/main:
  Fix EasyMDE error when input Enter (go-gitea#19004)
  Fix update hint bug (go-gitea#18996)
  Fix the editor height in review box (go-gitea#19003)
  Add a "admin user generate-access-token" subcommand (go-gitea#17722)
  Fix potential assignee query for repo (go-gitea#18994)
  Add config option to disable "Update branch by rebase" (go-gitea#18745)
  Update `go-enry` to v2.8.0 (go-gitea#18993)
  homebrew updates via cron
  ignore missing comment for user notifications (go-gitea#18954)
  allow overwrite artifacts for github releases (go-gitea#18987)
  fix & refactor (go-gitea#18973)
@noerw noerw mentioned this pull request Mar 8, 2022
Merged
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@fnetX @6543 @lunny
Fix potential assignee query for repo (go-gitea#18994)
c35db71 
* Fix potential assignee query for repo

* Add tests for `GetRepoAssignees`

- As per go-gitea#18994 (comment)

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: Gusted <williamzijl7@hotmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gusted Gusted Gusted approved these changes

@zeripath zeripath zeripath approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

User assignment proposals broken
7 participants
@fnetX @Gusted @codecov-commenter @lunny @zeripath @GiteaBot @6543