Use ctx instead of db.DefaultContext in some packages(routers/services/modules)
#19163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
force-pushed
the
refactor-db-in-router
branch
from
025f2a7 to
6d5f307
Compare
wxiaoguang
added
type/refactoring
wxiaoguang
changed the title
db.DefaultContext usage in routers, use ctx directlydb.DefaultContext usage in some packages(routers/services), use ctx directly
wxiaoguang
changed the title
db.DefaultContext usage in some packages(routers/services), use ctx directlyctx instead of db.DefaultContext in some packages(routers/services/modules)
zeripath
approved these changes
Mar 22, 2022
GiteaBot
added
the
lgtm/need 1
Closed
lunny
approved these changes
Mar 22, 2022
GiteaBot
added
lgtm/done
6543
approved these changes
Mar 22, 2022
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 23, 2022
* giteaofficial/main: Remove the Go version in UI, add a link on Gitea Version to show config details (Go/Git version) (go-gitea#19173) [skip ci] Updated translations via Crowdin Clean paths when looking in Storage (go-gitea#19124) Use the new/choose link for New Issue on project page (go-gitea#19172) Ensure that setting.LocalURL always has a trailing slash (go-gitea#19171) Use `ctx` instead of `db.DefaultContext` in some packages(routers/services/modules) (go-gitea#19163)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
…vices/modules) (go-gitea#19163) * Remove `db.DefaultContext` usage in routers, use `ctx` directly * Use `ctx` directly if there is one, remove some `db.DefaultContext` in `services` * Use ctx instead of db.DefaultContext for `cmd` and some `modules` packages * fix incorrect context usage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as the title. from discussion: #19010 (comment)
db.GetEnginecan accept any context, so we should use thectxdirectly if there is one.This PR is just a simple search&replace.