Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User specific repoID or xorm builder conditions for issue search #19475

Merged
merged 8 commits into from
Apr 25, 2022
Merged

User specific repoID or xorm builder conditions for issue search #19475

merged 8 commits into from
Apr 25, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented Apr 24, 2022

Close #19368

@6543 6543 added type/bug pr/wip This PR is not ready for review performance/speed performance issues with slow downs labels Apr 24, 2022
@6543 6543 added this to the 1.17.0 milestone Apr 24, 2022
@6543 6543 removed the pr/wip This PR is not ready for review label Apr 24, 2022
@6543 6543 mentioned this pull request Apr 24, 2022
Closed
6543 added a commit to 6543-forks/gitea that referenced this pull request Apr 24, 2022
@6543
User specific repoID or xorm builder conditions for issue search (go-…
d4af773 
…gitea#19475)
@6543 6543 mentioned this pull request Apr 24, 2022
Merged
6543
6543 commented Apr 24, 2022
View reviewed changes
models/issue.go Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 24, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #19475 (9b06c32) into main (d242511) will decrease coverage by 0.17%.
The diff coverage is 44.43%.

@@            Coverage Diff             @@
##             main   #19475      +/-   ##
==========================================
- Coverage   47.51%   47.33%   -0.18%     
==========================================
  Files         944      951       +7     
  Lines      131549   132353     +804     
==========================================
+ Hits        62500    62649     +149     
- Misses      61541    62157     +616     
- Partials     7508     7547      +39
Impacted Files Coverage Δ
cmd/dump.go 0.71% <0.00%> (-0.01%) ⬇️
cmd/serv.go 2.33% <0.00%> (-0.06%) ⬇️
models/action.go 48.61% <0.00%> (ø)
models/error.go 36.46% <ø> (-0.03%) ⬇️
models/issue_label.go 68.46% <0.00%> (+0.44%) ⬆️
models/issue_lock.go 0.00% <0.00%> (ø)
models/issue_project.go 31.70% <0.00%> (ø)
models/organization/team_repo.go 76.19% <0.00%> (ø)
models/statistic.go 0.00% <0.00%> (ø)
models/unittest/testdb.go 14.49% <0.00%> (-1.14%) ⬇️
... and 143 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0abd8b0...9b06c32. Read the comment docs.

@6543 6543 added the backport/done All backports for this PR have been created label Apr 24, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 25, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 25, 2022
6543 added a commit that referenced this pull request Apr 25, 2022
@6543
User specific repoID or xorm builder conditions for issue search (#19475
8d7f1e4 
) (#19476)
@6543 6543 merged commit ddbbe6e into go-gitea:main Apr 25, 2022
@6543 6543 deleted the fix_api_issue-search_19368 branch April 25, 2022 14:06
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 25, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
430a8fa 
* giteaofficial/main:
  User specific repoID or xorm builder conditions for issue search (go-gitea#19475)
  Add notags to fetch (go-gitea#19487)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@6543 @AbdulrhmnGhanem
User specific repoID or xorm builder conditions for issue search (go-…
15e2f2e 
…gitea#19475)

* extend models.IssuesOptions to have more specific repo filter options

* use new options

* unrelated refactor

* rm RepoIDs
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gusted Gusted Gusted approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. performance/speed performance issues with slow downs type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

Linking issue dependencies fails (API returns 500 error)
5 participants
@6543 @codecov-commenter @lunny @Gusted @GiteaBot