Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RequireHighlightJS field, update plantuml example. #19615

Merged
merged 1 commit into from
May 5, 2022
Merged

Remove RequireHighlightJS field, update plantuml example. #19615

merged 1 commit into from
May 5, 2022

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented May 5, 2022 •
edited
Loading

The RequireHighlightJS doesn't work well, and it should be removed. It has been obsolete for a long time (since #17365)

Frontend code should use other methods (eg: check '.language-plantuml') to load external JS renders. Fix #19110

(ps: the code of plantuml_codeblock_parse.js is not modularized, but that's another story)

⚠️ BREAKING ⚠️

The RequireHighlightJS is removed from template data, you should not use it anymore.

@wxiaoguang wxiaoguang added topic/ui Change the appearance of the Gitea UI type/refactoring Existing code has been cleaned up. There should be no new functionality. pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! labels May 5, 2022
@wxiaoguang wxiaoguang added this to the 1.17.0 milestone May 5, 2022
@wxiaoguang wxiaoguang mentioned this pull request May 5, 2022
Closed
@wxiaoguang wxiaoguang force-pushed the remove-requirehighlightjs branch from f384f0f to 7807cd7 Compare May 5, 2022 05:48
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 5, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 5, 2022
@lafriks lafriks merged commit 7b089c4 into go-gitea:main May 5, 2022
@wxiaoguang wxiaoguang deleted the remove-requirehighlightjs branch May 5, 2022 09:20
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 5, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
eef822a 
* giteaofficial/main:
  Call MultipartForm.RemoveAll when request finishes (go-gitea#19606)
  Remove `RequireHighlightJS` field, update plantuml example. (go-gitea#19615)
  [skip ci] Updated translations via Crowdin
  PullService lock via pullID (go-gitea#19520)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@wxiaoguang @AbdulrhmnGhanem
Remove RequireHighlightJS field, update plantuml example. (go-gitea…
ba8073c 
…#19615)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! topic/ui Change the appearance of the Gitea UI type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

Plantuml not rendering in Readme only in Issues and Wiki
4 participants
@wxiaoguang @lunny @lafriks @GiteaBot