Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue overview for teams (#19652) #19653

Merged
merged 6 commits into from
May 16, 2022
Merged

Fix issue overview for teams (#19652) #19653

merged 6 commits into from
May 16, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented May 8, 2022

Fix issue overview for teams (go-gitea#19652)
a3ddd73 
- Backport go-gitea#19652
  - Don't use hacky solution to limit to the correct RepoID's, instead use current code to handle these limits. The existing code is more correct than the hacky solution.
  - Resolves go-gitea#19636
@Gusted Gusted added this to the 1.16.8 milestone May 8, 2022
@Gusted Gusted added the issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself label May 8, 2022
@KN4CK3R
Copy link
Member

KN4CK3R commented May 8, 2022

CI fail seems related.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 8, 2022
@lunny lunny modified the milestones: 1.16.8, 1.16.9 May 10, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 11, 2022
@Gusted Gusted modified the milestones: 1.16.9, 1.16.8 May 14, 2022
@wxiaoguang
Copy link
Contributor

Looks good, it's worth to have this in 1.16.8

Could @jpraet help to double check if this fix works correctly?

@jpraet
Copy link
Member

jpraet commented May 16, 2022

Could @jpraet help to double check if this fix works correctly?

Yes, with this fix the issue totals are correct.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 16, 2022
@wxiaoguang wxiaoguang merged commit 38acce2 into go-gitea:release/v1.16 May 16, 2022
@Gusted Gusted deleted the backport-19652 branch May 16, 2022 09:50
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Milestone
1.16.8
Development

Successfully merging this pull request may close these issues.
8 participants
@Gusted @KN4CK3R @wxiaoguang @jpraet @lafriks @lunny @GiteaBot @techknowlogick