-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go tool dependencies #19676
Merged
Merged
Update go tool dependencies #19676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated all tool dependencies to latest tags, hoping CI will like it.
6543
reviewed
May 10, 2022
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
May 10, 2022
New lint errors should be handled now. |
ed1d95c had disabled the |
6543
approved these changes
May 10, 2022
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
May 10, 2022
techknowlogick
approved these changes
May 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @silverwind <3
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
May 10, 2022
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 11, 2022
* giteaofficial/main: Fix oauth setting list bug (go-gitea#19682) Delete user related oauth stuff on user deletion too (go-gitea#19677) Move access and repo permission to models/perm/access (go-gitea#19350) Tidy up `<head>` template (go-gitea#19678) Update go tool dependencies (go-gitea#19676) Update JS dependencies (go-gitea#19675)
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
* Update go tool dependencies Updated all tool dependencies to latest tags, hoping CI will like it. * fix new lint errors * handle more strings.Title cases * remove lint skip
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 3, 2023
Regression of go-gitea#19676 and go-gitea#21814 Fix go-gitea#23872 `cases.Title` is not thread-safe, it has internal state, so it can't be used as a global shared variable.
6543
pushed a commit
that referenced
this pull request
Apr 3, 2023
Backport #23885 by @wxiaoguang Regression of #19676 and #21814 Fix #23872 `cases.Title` is not thread-safe, it has internal state, so it can't be used as a global shared variable. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated all tool dependencies to latest tags, hoping CI will like it.