Skip to content

Backtick table name in generic orphan check #20019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2022
Merged

Backtick table name in generic orphan check #20019

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f198ba5
Backtick table name in generic orphan check
Jun 18, 2022
df10a9b
Merge branch 'main' into fix-orphan-check-doctor
Jun 18, 2022
1f17757
Merge branch 'main' into fix-orphan-check-doctor
Jun 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/doctor/dbconsistency.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,10 +201,10 @@ func checkDBConsistency(ctx context.Context, logger log.Logger, autofix bool) er
"oauth2_authorization_code", "oauth2_grant", "oauth2_authorization_code.grant_id=oauth2_grant.id"),
// find stopwatches without existing user
genericOrphanCheck("Orphaned Stopwatches without existing User",
"stopwatch", "user", "stopwatch.user_id=user.id"),
"stopwatch", "user", "stopwatch.user_id=`user`.id"),
// find stopwatches without existing issue
genericOrphanCheck("Orphaned Stopwatches without existing Issue",
"stopwatch", "issue", "stopwatch.issue_id=issue.id"),
"stopwatch", "issue", "stopwatch.issue_id=`issue`.id"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does issue need this as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No harm 🤷🏽(Simple ctrl-f shows multiple references and I have no idea when to use them 😄) I don't have a Postgres setup to test it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not consistent before and wont be after ... - I dont mid if this is changed too

)

for _, c := range consistencyChecks {
Expand Down