Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog v1.17.0-rc1 #20023

Merged
merged 16 commits into from
Jun 20, 2022
Merged

Changelog v1.17.0-rc1 #20023

merged 16 commits into from
Jun 20, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented Jun 18, 2022 •
edited by lunny
Loading

@6543 6543 added type/docs This PR mainly updates/creates documentation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. frontport/main This PR is not targeting the main branch. Still, its changes should also be added there labels Jun 18, 2022
@6543 6543 added this to the 1.17.0 milestone Jun 18, 2022
@6543 6543 changed the base branch from main to release/v1.17 June 18, 2022 17:06
6543
6543 commented Jun 18, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 18, 2022
@delvh
Copy link
Member

delvh commented Jun 18, 2022 •
edited
Loading

https://github.com/go-gitea/gitea/issues?q=milestone%3A1.17.0+is%3Aclosed+label%3Akind%2Fbreaking
has a little bit more...

6543
6543 commented Jun 18, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@6543
Copy link
Member Author

6543 commented Jun 18, 2022

https://github.com/go-gitea/gitea/issues?q=milestone%3A1.17.0+is%3Aclosed+label%3Akind%2Fbreaking has a little bit more...

strange ... wrong priorizing within https://github.com/go-gitea/gitea/blob/main/.changelog.yml ?

@delvh
Copy link
Member

delvh commented Jun 18, 2022

https://github.com/go-gitea/gitea/issues?q=milestone%3A1.17.0+is%3Aclosed+label%3Akind%2Fbreaking has a little bit more...

strange ... wrong priorizing within https://github.com/go-gitea/gitea/blob/main/.changelog.yml ?

Indeed. Make AppDataPath absolute against the AppWorkPath if it is not (#19815) for example is under bug.

6543
6543 commented Jun 18, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@6543 6543 requested a review from delvh June 18, 2022 18:34
@6543 6543 changed the title Changelog v1.17.0-rc0 Changelog v1.17.0-rc1 Jun 18, 2022
6543
6543 commented Jun 18, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@6543
Copy link
Member Author

6543 commented Jun 18, 2022

https://gitea.com/gitea/changelog/issues/61

next changelog generation will be better - cc @delvh

@6543
Copy link
Member Author

6543 commented Jun 18, 2022

ok I'm now fine with this as is - so it will get my LGTM - now we just more of them

Gusted
Gusted reviewed Jun 18, 2022
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 18, 2022
@6543
Apply suggestions from code review
e8ee095 
Co-authored-by: Gusted <williamzijl7@hotmail.com>
6543
6543 commented Jun 18, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 18, 2022
delvh
delvh reviewed Jun 18, 2022
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also notice: The CHANGELOG tool does not like backported breaking changes.

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@6543 @delvh
Apply suggestions from code review
bdc5b65 
Co-authored-by: delvh <dev.lh@web.de>
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jun 19, 2022 •
edited
Loading

@lunny
Copy link
Member

lunny commented Jun 19, 2022

All PRs backported and skip-change should be removed from changelog.

@6543
Copy link
Member Author

6543 commented Jun 19, 2022

All PRs backported and skip-change should be removed from changelog.

If not added manualy they should never have been in here...

lafriks
lafriks reviewed Jun 19, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@jpraet
Copy link
Member

jpraet commented Jun 20, 2022

Shouldn't this be mentioned in the changelog? #18971

Although these error messages are quite self-explanatory, people may wonder why they appear suddenly after upgrading to 1.17.

@6543
Copy link
Member Author

6543 commented Jun 20, 2022

🚀

@6543 6543 merged commit 710a141 into go-gitea:release/v1.17 Jun 20, 2022
@6543 6543 deleted the changelog_v1.17.0-rc0 branch June 20, 2022 13:09
@Gusted
Copy link
Contributor

Gusted commented Jun 20, 2022

Shouldn't this be mentioned in the changelog? #18971

Probably should be mentioned in the blog post for 1.17.0

@6543
Copy link
Member Author

6543 commented Jun 20, 2022

It's only an rc atm ...

@6543 6543 removed the frontport/main This PR is not targeting the main branch. Still, its changes should also be added there label Jun 20, 2022
@6543
Copy link
Member Author

6543 commented Jun 20, 2022

I think we dont have to frontport until we do the big release

@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@lafriks lafriks lafriks left review comments

@lunny lunny lunny left review comments

@Gusted Gusted Gusted approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
9 participants
@6543 @delvh @wxiaoguang @lunny @jpraet @Gusted @lafriks @GiteaBot @zeripath