-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace pubkey with privkey in keys_ssh.tmpl #20112
Conversation
If a user wants to verify an SSH public key from their account they have to sign the randomly generated token with their private key. Prior to this change the example command prompted to sign the token with their public key instead. Signed-off-by: Robert Lützner <robert.luetzner@pm.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should work with pub too as it points to the priv ...
but directly pointing to priv do also work
@6543 , you're right. I didn't check that yesterday, but tried it out just now. I encountered an issue when verifying my SSH key yesterday. It basically told me that something seems to have expired. Maybe if I had just retried it immediately with the path to my public key it would have worked as well. I used my private key the second time around and it worked, so I assumed that the hint is wrong. Thanks for clearing that up. 🙂 |
According to
Keep the |
oh damed - just merged :X |
nvm, either is fine. indeed the purpose is to check the key itself. private key works in all cases. |
* giteaoffical/main: Move eslintrc/stylelintrc to non-deprecated extensions (go-gitea#20110) Allow manager logging to set SQL (go-gitea#20064) Replace pubkey with privkey in keys_ssh.tmpl (go-gitea#20112) Update security information to add a public gpg key to make sending encrypted message possible (go-gitea#20117)
If a user wants to verify an SSH public key from their account they have to sign the randomly generated token with their private key. Prior to this change the example command prompted to sign the token with their public key instead. Signed-off-by: Robert Lützner <robert.luetzner@pm.me>
If a user wants to verify an SSH public key from their account they have
to sign the randomly generated token with their private key.
Prior to this change the example command prompted to sign the token with
their public key instead.
Signed-off-by: Robert Lützner robert.luetzner@pm.me