Fix dump-repo git init, fix wrong error type for NullDownloader (#20182)
#20186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
approved these changes
Jun 30, 2022
GiteaBot
added
the
lgtm/need 1
wxiaoguang
changed the title
dump-repo git init (#20182)dump-repo git init, fix wrong error type for NullDownloader (#20182)
|
CI failure is related. |
https://drone.gitea.io/go-gitea/gitea/56933/3/8 I do not think it's related ...... restarted and passed. |
wxiaoguang
added
the
skip-changelog
delvh
approved these changes
Jul 1, 2022
GiteaBot
added
lgtm/done
|
🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #20182
The dump-repo sub-command should initialize the git module before calling git commands.
And NullDownloader returned wrong error type, which stops dump-repo command, it's fixed together.