Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if project has the same repository id with issue when assign project to issue (#20133) #20188

Merged
merged 2 commits into from
Jul 1, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 30, 2022

backport from #20133

  • Check if project has the same repository id with issue when assign project to issue

  • Check if issue's repository id match project's repository id

  • Add more permission checking

  • Remove invalid argument

  • Fix errors

  • Add generic check

  • Remove duplicated check

  • Return error + add check for new issues

  • Apply suggestions from code review

Co-authored-by: KN4CK3R admin@oldschoolhack.me

Co-authored-by: Gusted williamzijl7@hotmail.com
Co-authored-by: KN4CK3R admin@oldschoolhack.me
Co-authored-by: 6543 6543@obermui.de

…oject to issue (go-gitea#20133)

* Check if project has the same repository id with issue when assign project to issue

* Check if issue's repository id match project's repository id

* Add more permission checking

* Remove invalid argument

* Fix errors

* Add generic check

* Remove duplicated check

* Return error + add check for new issues

* Apply suggestions from code review

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>

Co-authored-by: Gusted <williamzijl7@hotmail.com>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: 6543 <6543@obermui.de>
@lunny lunny added the type/bug label Jun 30, 2022
@lunny lunny added this to the 1.17.0 milestone Jun 30, 2022
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have better commit logs in history?

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 30, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 30, 2022
@6543
Copy link
Member

6543 commented Jul 1, 2022

🚀

@6543 6543 merged commit 3e4fe00 into go-gitea:release/v1.17 Jul 1, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
@lunny lunny deleted the lunny/fix_assign_project2 branch August 24, 2023 11:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants