Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog v1.17.0-rc2 #20350

Merged
merged 13 commits into from
Jul 19, 2022
Merged

Changelog v1.17.0-rc2 #20350

merged 13 commits into from
Jul 19, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented Jul 12, 2022 •
edited
Loading

No description provided.

@6543 6543 added type/docs This PR mainly updates/creates documentation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jul 12, 2022
@6543 6543 added this to the 1.17.0 milestone Jul 12, 2022
@wxiaoguang

This comment was marked as resolved.

Sign in to view
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 13, 2022
delvh
delvh reviewed Jul 17, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
zeripath
zeripath reviewed Jul 17, 2022
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@6543 @zeripath
Apply suggestions from code review
0fb03b9 
Co-authored-by: zeripath <art27@cantab.net>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 17, 2022
zeripath
zeripath approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna approve as I think we should just release the next rc soon.

@go-gitea/mergers double check before merging that the changelog is up-to-date and that there isn't anything drastically missing.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 19, 2022
@6543
Copy link
Member Author

6543 commented Jul 19, 2022

🚀

@6543 6543 merged commit 2c93bd7 into go-gitea:release/v1.17 Jul 19, 2022
@6543 6543 deleted the changelog_v1.17.0-rc2 branch July 19, 2022 13:43
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @wxiaoguang @zeripath @delvh @GiteaBot