Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise golangci-lint timeout #20441

Closed
wants to merge 1 commit into from
Closed

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Jul 21, 2022

Some recent failures on CI with timeout, let's raise it a bit.

Some recent failures on CI with timeout, let's raise it a bit.
@silverwind silverwind added type/testing skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jul 21, 2022
@6543
Copy link
Member

6543 commented Jul 21, 2022

in this case the worker instance is just slow ... and at some point the pieline run limit will kill it too ...

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 21, 2022
@silverwind
Copy link
Member Author

Yeah, it's generally the workers being slow recently, golint usually only takes 3 minutes and we are now at/over close to 10 minutes. What is the pipeline limit set too?

@6543
Copy link
Member

6543 commented Jul 21, 2022

90min ... but drone often does not respect it and they can run infinte :/

@silverwind
Copy link
Member Author

FWIW, it finished in 15min in this run:

image

Definitely an infrastructure issue thought.

@6543
Copy link
Member

6543 commented Jul 21, 2022

local runtime:

time make lint-backend
________________________________________________________
Executed in  163.33 secs    fish           external
   usr time   33.76 mins  403.00 micros   33.76 mins
   sys time   11.48 mins    0.00 micros   11.48 mins

-> 2min, 42sec

@silverwind
Copy link
Member Author

Seems it's a bit recovering. Let's leave the timeout then.

@silverwind silverwind closed this Jul 21, 2022
@silverwind
Copy link
Member Author

Actually, slowness looks to be related to golangci/golangci-lint#2997.

@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants