Fix Ruby spec parsing #20470
Merged
Fix Ruby spec parsing #20470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not the job of a YAML parser, but our own code, generally speaking. |
GiteaBot
added
the
lgtm/need 2
|
You could create new type StringArray []string with UnmarshalYAML function that would support both single email as string or array of strings |
|
Sure, but this field is not needed. There is no benefit of having it at the moment. |
|
As it's easy to fix I would go for new type ... - should I push to your branch @KN4CK3R ? |
|
Sure, but this field is not needed. :-) |
zeripath
approved these changes
Jul 24, 2022
GiteaBot
added
lgtm/need 1
|
well this is backportable ... |
6543
approved these changes
Jul 24, 2022
GiteaBot
added
lgtm/done
|
. |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 25, 2022
* giteaofficial/main: Fix Ruby package parsing by removed unused email field (go-gitea#20470) [skip ci] Updated translations via Crowdin Add repository condition for issue count (go-gitea#20454) Prepend commit message to template content (go-gitea#20429) Improve pprof doc (go-gitea#20463) Improve code diff highlight, fix incorrect rendered diff result (go-gitea#19958) Add Cache-Control header to html and api responses, add no-transform (go-gitea#20432) [skip ci] Updated translations via Crowdin Allow non-semver packages in the Conan package registry (go-gitea#20412) Use body text color in repository files table links (go-gitea#20386) Correct code block in installation docs for Snap (go-gitea#20440) Downgrade golangci-lint to 1.47.0 (go-gitea#20445) Add eslint-plugin-sonarjs (go-gitea#20431) Fix: Actor is required to get user repositories (go-gitea#20443) Add "X-Gitea-Object-Type" header for GET `/raw/` & `/media/` API (go-gitea#20438) Simplify visibility checks (go-gitea#20406)
6543
pushed a commit
to 6543-forks/gitea
that referenced
this pull request
Jul 28, 2022
|
-> #20525 |
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19837
Problem is the
emailfield which can be a string or an array of strings. The yaml parser does not support (?) the parsing of a single string into an array so I just removed the field as it is not used.