Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ROOT_URL detection for URLs without trailing slash #20502

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Fix ROOT_URL detection for URLs without trailing slash #20502

merged 1 commit into from
Jul 27, 2022

Conversation

wxiaoguang
Copy link
Contributor

Some users visit "https://domain/gitea" while appUrl is "https://domain/gitea/", there should be no warning

Close #20501

@wxiaoguang wxiaoguang mentioned this pull request Jul 27, 2022
Closed
@wxiaoguang wxiaoguang modified the milestones: 1.17.0, 1.18.0 Jul 27, 2022
@wxiaoguang wxiaoguang added type/bug topic/ui Change the appearance of the Gitea UI skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jul 27, 2022
@wxiaoguang wxiaoguang mentioned this pull request Jul 27, 2022
Merged
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 27, 2022
@wxiaoguang wxiaoguang added backport/done All backports for this PR have been created backport/v1.17 labels Jul 27, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 27, 2022
@wxiaoguang wxiaoguang merged commit 158f274 into go-gitea:main Jul 27, 2022
@wxiaoguang wxiaoguang deleted the fix-root-url-detection branch July 27, 2022 09:19
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 28, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
bddab98 
* giteaofficial/main:
  Removed some vestigial code related to Range bounds checks (go-gitea#20312)
  Add markdownlint (go-gitea#20512)
  Fix possible panic when repository is empty (go-gitea#20509)
  patch (doc): add heading to ssh flow explanation (go-gitea#20506)
  Show hint to link package to repo when viewing empty repo package list (go-gitea#20504)
  Fix ROOT_URL detection for URLs without trailing slash (go-gitea#20502)
  Add Tar ZSTD support (go-gitea#20493)
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
@wxiaoguang
Fix ROOT_URL detection for URLs without trailing slash (go-gitea#20502)
ee52028
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.

[1.17.0-RC2] Incorrect ROOT_URL warning when using proxy through apache
4 participants
@wxiaoguang @lunny @zeripath @GiteaBot