Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add merge files files to GetCommitFileStatus #20515

Merged
merged 6 commits into from
Aug 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/git/commit.go
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@ func GetCommitFileStatus(ctx context.Context, repoPath, commitID string) (*Commi
}()

stderr := new(bytes.Buffer)
err := NewCommand(ctx, "log", "--name-status", "-c", "--pretty=format:", "--parents", "--no-renames", "-z", "-1").AddDynamicArguments(commitID).Run(&RunOpts{
err := NewCommand(ctx, "log", "--name-status", "-m", "--pretty=format:", "--first-parent", "--no-renames", "-z", "-1").AddDynamicArguments(commitID).Run(&RunOpts{
Dir: repoPath,
Stdout: w,
Stderr: stderr,
Expand Down
23 changes: 23 additions & 0 deletions modules/git/commit_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -255,3 +255,26 @@ func TestParseCommitFileStatus(t *testing.T) {
assert.Equal(t, kase.modified, fileStatus.Modified)
}
}

func TestGetCommitFileStatusMerges(t *testing.T) {
bareRepo1Path := filepath.Join(testReposDir, "repo6_merge")

commitFileStatus, err := GetCommitFileStatus(DefaultContext, bareRepo1Path, "022f4ce6214973e018f02bf363bf8a2e3691f699")
assert.NoError(t, err)

expected := CommitFileStatus{
[]string{
"add_file.txt",
},
[]string{
"to_remove.txt",
},
[]string{
"to_modify.txt",
},
}

assert.Equal(t, commitFileStatus.Added, expected.Added)
assert.Equal(t, commitFileStatus.Removed, expected.Removed)
assert.Equal(t, commitFileStatus.Modified, expected.Modified)
}
1 change: 1 addition & 0 deletions modules/git/tests/repos/repo6_merge/HEAD
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ref: refs/heads/main
Binary file not shown.
Binary file not shown.
Binary file not shown.
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
x��M
1 �a�=E��$��LAī�'���i��R���g�~_��u1��N��@mZ)g�2�D�j��*_�f��s �4��a�m�np>�����>!��#���1�;p]�x��uyIw�N4�
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
x��M
�0�a�9����M2 �U�� ��=���yv/��� ��0:@��$��UѬ�.�[�>� �l��I�s�x ��8'T��R�ĤS,��$x. ֚�=n[��נ��u�s!+9���BGv�f�m���u���r����>�
Expand Down
Binary file not shown.
Binary file not shown.
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
x��M
1 @a�=E���?i�*m��Ǒ�xO���=x�.�l��O��R�Z80��\[�*�%�b
�&q��� �I��Ț�灝
7��ԋF쨜�w�c�u���zx?����0�
�1 :�m���6L�S���>&
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
1 change: 1 addition & 0 deletions modules/git/tests/repos/repo6_merge/refs/heads/main
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
022f4ce6214973e018f02bf363bf8a2e3691f699
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ae4b035e7c4afbc000576cee3f713ea0c2f1e1e2
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
d1792641396ff7630d35fbb0b74b86b0c71bca77
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
38ec3e0cdc88bde01014bda4a5dd9fc835f41439