Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages/generic: Do not restrict package versions to SemVer (#20414) #20531

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented Jul 28, 2022

backport #20414

There are existing packages out there whose version do not conform to SemVer, yet, one would like to have them available in a generic package repository. To this end, remove the SemVer restriction on package versions when using the Generic package registry, and replace it with a check that simply makes sure the version isn't empty.

Signed-off-by: Gergely Nagy me@gergo.csillger.hu
Co-authored-by: KN4CK3R admin@oldschoolhack.me
Co-authored-by: 6543 6543@obermui.de

…a#20414)

There are existing packages out there whose version do not conform to SemVer, yet, one would like to have them available in a generic package repository. To this end, remove the SemVer restriction on package versions when using the Generic package registry, and replace it with a check that simply makes sure the version isn't empty.

Signed-off-by: Gergely Nagy <me@gergo.csillger.hu>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: 6543 <6543@obermui.de>
@6543 6543 added this to the 1.17.0 milestone Jul 28, 2022
@6543 6543 added topic/distribution This PR changes something about the packaging of Gitea topic/packages type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jul 28, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 28, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 28, 2022
@6543 6543 merged commit ae86a0b into go-gitea:release/v1.17 Jul 28, 2022
@6543 6543 deleted the backport-20414 branch July 28, 2022 23:17
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/distribution This PR changes something about the packaging of Gitea topic/packages type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants