Skip to content

Added email notification option to receive all own messages (#20179) #20532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Added email notification option to receive all own messages (#20179) #20532

wants to merge 1 commit into from
+19 −12

Conversation

@tyroneyeh
Copy link
Contributor

@tyroneyeh tyroneyeh commented Jul 29, 2022

Backport #20179

@tyroneyeh
Added email notification option to receive all own messages (go-gitea…
20e8c8c 
…#20179)

Sometimes users want to receive email notifications of messages they create or reply to,
Added an option to personal preferences to allow users to choose

Closes go-gitea#20149
a1012112796
a1012112796 reviewed Jul 29, 2022
View reviewed changes
Copy link
Member

@a1012112796 a1012112796 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not necessay to backport the feature ...

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 29, 2022
@tyroneyeh
Copy link
Contributor Author

tyroneyeh commented Jul 29, 2022

But 1.17 has not been released yet, I hope this feature can be included from the old version update, what do other people think?

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jul 29, 2022

Thank you for your PR and backport.

According Gitea's release plan, the stable and rc releases only get bug fixes, but not features or enhancements.

https://github.com/go-gitea/gitea/blob/main/CONTRIBUTING.md#release-cycle

All the feature pull requests should be merged before feature freeze. 
And, during the frozen period, a corresponding release branch is open for fixes backported from main branch.
Release candidates are made during this period for user testing to obtain a final version that is maintained in this branch.
A release is maintained by issuing patch releases to only correct critical problems such as crashes or security issues.

@6543
Copy link
Member

6543 commented Jul 29, 2022

sorry enhancements where backported in some edgecases, but features wont

@6543 6543 closed this Jul 29, 2022
@tyroneyeh tyroneyeh deleted the 20179-backport branch July 29, 2022 11:48
@tyroneyeh
Copy link
Contributor Author

tyroneyeh commented Jul 29, 2022

😭

@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@a1012112796 a1012112796 a1012112796 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tyroneyeh @wxiaoguang @6543 @a1012112796 @GiteaBot