Stop logging CheckPath returns error: context canceled #21064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should only log CheckPath errors if they are not simply due to context cancellation. Fix go-gitea#20709 Signed-off-by: Andrew Thornton <art27@cantab.net>
delvh
reviewed
Sep 4, 2022
GiteaBot
added
the
lgtm/need 2
Co-authored-by: delvh <dev.lh@web.de>
delvh
approved these changes
Sep 4, 2022
GiteaBot
added
lgtm/need 1
|
Does it conflict with #20823? |
|
@silverwind I guess it is orthogonal to #20823 |
|
Peeps this PR would remove a lot of confusing log messages. It would be good to get it merged |
Gusted
approved these changes
Oct 10, 2022
GiteaBot
added
lgtm/done
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Oct 10, 2022
Backport go-gitea#21064 We should only log CheckPath errors if they are not simply due to context cancellation - and we should add a little more context to the error message. Fix go-gitea#20709 Signed-off-by: Andrew Thornton <art27@cantab.net>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Oct 11, 2022
* upstream/main: Add user/organization code search (go-gitea#19977) Stop logging CheckPath returns error: context canceled (go-gitea#21064) Hook go-licenses into tidy again (go-gitea#21353) Fix missing left and right carets in TRANSLATORS (go-gitea#21397) Fix calls to i18n in templates (go-gitea#21394) Update JS dependencies and eslint config (go-gitea#21388) Allow creation of OAuth2 applications for orgs (go-gitea#18084) Fix typos in PullRequestMergeForm.vue header comment (go-gitea#21378) Use weighted algorithm for string matching when finding files in repo (go-gitea#21370) Bump playwright to 1.26.1 (go-gitea#21357) npm package registry support for `bin` (go-gitea#21372) Removed one extra whitespace in footer after "Template" (go-gitea#21364)
tyroneyeh
pushed a commit
to tyroneyeh/gitea
that referenced
this pull request
Oct 24, 2022
… (go-gitea#21405) Backport go-gitea#21064 We should only log CheckPath errors if they are not simply due to context cancellation - and we should add a little more context to the error message. Fix go-gitea#20709 Signed-off-by: Andrew Thornton <art27@cantab.net> Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should only log CheckPath errors if they are not simply due to context cancellation - and we should add a little more context to the error message.
Fix #20709
Signed-off-by: Andrew Thornton art27@cantab.net